Add the option to change some parameters with command line options.#7
Open
PaddyWan wants to merge 2 commits intomaxilevi:mainfrom
Open
Add the option to change some parameters with command line options.#7PaddyWan wants to merge 2 commits intomaxilevi:mainfrom
PaddyWan wants to merge 2 commits intomaxilevi:mainfrom
Conversation
maxilevi
requested changes
Aug 21, 2024
test/main.cpp
Outdated
|
|
||
| //rng.seed(params.seed); | ||
|
|
||
| auto result = vits_model_process(model, phrase); |
Owner
There was a problem hiding this comment.
Here phrase is not declared, can you use params.phrase.c_str()?
Contributor
Author
There was a problem hiding this comment.
Yes that was a typo from me, because I did a few changes at the same time. It is indeed params.phrase.c_str(). Already have changed the rng from the other pull request, you could also uncomment the rng.seed(params.seed);.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now has the ability to use command line parameters. Not using any would return to the defaults like before.